谷氨酸钠是什么| 五不遇时是什么意思| 覆盆子有什么作用| mirror什么意思| 麻药叫什么名字| 胎儿双顶径偏大是什么原因| 5月20日是什么日子| 为什么叫梅雨季节| 补肾壮阳吃什么好| 埋线是什么| 落下帷幕什么意思| 四风指什么| 白天不咳嗽晚上咳嗽吃什么药| 人流后可以吃什么水果| 什么家庭养出自私冷漠| 为什么会骨盆前倾| 干咳嗽无痰是什么原因| 庶母是什么意思| 癸未日五行属什么| 格林是什么意思| 女性尿路感染有什么症状| 花非花雾非雾什么意思| 大脑供血不足吃什么药最好| 野生蜂蜜有什么好处和作用| 年终奖一般什么时候发| 低血压头晕吃什么药| 毕加索全名是什么| 肺热吃什么药| 女人物质是什么意思| 214是什么意思| 指检是什么| 室缺是什么意思| 放下身段是什么意思| 睡觉多梦是什么原因引起的| 慢性盆腔炎吃什么药效果好| 什么的兵马俑| 透析是什么| 血糖高去医院挂什么科| 咳嗽一直不好什么原因| 宫颈炎是什么| 孔雀吃什么食物| 山竹里面黄黄的是什么| 老戏骨是什么意思| 每逢佳节倍思亲的上一句是什么| 夏朝前面是什么朝代| 素鸡是用什么做的| 水杉是什么植物| 早晨口苦是什么原因| 最近爆发什么病毒感染| 第一次同房是什么感觉| 贾蓉和王熙凤是什么关系| 牙齿一碰就疼是什么原因| 搀扶什么意思| 胰腺炎是什么| 夏对什么| 梦见自己会开车了是什么意思| 终其一生下一句是什么| 汉尼拔什么意思| 月经正常颜色是什么色| 现在创业做什么好| 说梦话是什么原因引起的| 1月24日是什么星座| 什么病不能熬夜| 木耳和什么菜搭配好吃| 什么的什么是什么的伞| 全身淋巴结肿大是什么原因| 仰角是什么意思| 豆汁是什么| 宝批龙是什么意思| 梦到自己流鼻血是什么预兆| 左室舒张功能减低吃什么药| rap什么意思| 什么叫小微企业| 6.4是什么星座| 挚友是什么意思| 相安无事什么意思| 心率是什么| 什么人容易得脑梗| 甲苯是什么| 早晨嘴苦是什么原因引起的| 静修是什么意思| 非布司他片是什么药| 尿里带血是什么原因男性| 帆布是什么材质| 芹菜什么时候种| 昆布是什么| 分泌物是褐色是什么原因| nsfw什么意思| 梦到借钱给别人什么意思| 九个月的宝宝吃什么辅食食谱| 10.5是什么星座| 沙里瓦是什么意思| 辩证什么意思| 什么是eb病毒| iqr是什么意思| 拐子是什么鱼| 业力是什么意思| 矬是什么意思| 0属于什么数| 很难怀孕是什么原因| 看头发应该挂什么科| 龟头炎用什么药治疗| 桂鱼吃什么食物| 什么人容易得布病| 橙字五行属什么| 工匠精神的核心是什么| 为什么口腔溃疡| 项羽姓什么| 火龙果什么时候成熟| 定坤丹什么时候吃最好| 蚯蚓靠什么运动| xswl是什么意思| 巴西货币叫什么| 脸两侧长痘痘是什么原因| 荆芥不能和什么一起吃| 足跟疼痛用什么药| 广东是什么气候| 什么地指挥| afar是什么意思| 海松茸是什么东西| 手表什么牌子| 胃溃疡a2期是什么意思| 飞舞是什么意思| 江西的简称是什么| 总胆固醇什么意思| 吃虾有什么好处| 什么是音序| 夫妻相是什么意思| 骆驼奶有什么功效| 虐狗什么意思| 天真是什么意思| 屁眼疼痛什么原因| 脖子上长个包挂什么科| 平顶山为什么叫平顶山| 瓦特发明了什么| 香港有什么好玩的| 帕金森挂什么科| 肠道为什么会长息肉| itp是什么病的简称| 频次是什么意思| 最近老放屁是什么原因| 什么是溶血性疾病| 探囊取物是什么意思| 拉青色大便是什么原因| 持之以恒的恒是什么意思| 天意不可违是什么意思| 减肥可以吃什么菜| 什么坚果适合减肥吃| 晚上吃什么不长肉| 散光跟近视有什么区别| 手指尖发麻是什么原因| 口头禅是什么意思| 粉籍是什么意思| 阿司匹林肠溶片有什么副作用| 缺维生素b有什么症状| 发烧惊厥是什么症状| 股市pe是什么意思| 打嗝是什么毛病| 偏头痛挂什么科| 红茶是什么茶| 不什么为什么| 狂蜂浪蝶是什么意思| 出圈是什么意思| 什么叫业力| 脾不统血吃什么中成药| 肝虚火旺吃什么中成药| coat是什么意思中文| 西康省是现在什么地方| 堃怎么读什么意思| 宋江是什么星| 缅怀是什么意思| 血管瘤是什么引起的| 左舌根疼痛是什么情况| 政治信仰是什么| 梦到死人是什么预兆| 小腿肚疼是什么原因| 2月18是什么星座| 印代表什么| 柠檬水有什么好处| 男人嘴小代表什么意思| 红斑狼疮什么症状| 沈阳为什么叫盛京| 眼睛出现飞蚊症什么原因怎么办| 一进门见到什么植物好| 胖大海配什么喝治咽炎| 口腔医学学什么| 异地补办身份证需要什么手续| 为什么拉屎会有血| 色素沉着有什么办法可以去除| 迎春花什么时候开花| 辣椒是什么科| 化疗吃什么补白细胞| 什么叫心悸| 什么的工作| 沙棘原浆什么人不能喝| 解脲脲原体阳性是什么| lf是什么意思| 2 26是什么意思| 一本万利是什么生肖| 百什么争鸣成语| 双顶径是什么| 皂角米是什么东西| 痛风吃什么蔬菜| 解脲支原体阳性吃什么药最好| 什么是好朋友| 41年属什么生肖| 猫咪为什么害怕黄瓜| 乳房疼痛吃什么消炎药| 寒湿体质吃什么中成药| bc是什么牌子| 什么病不能吃西洋参| 诛心是什么意思| 子官肌瘤吃什么食物| 血糖高喝什么豆浆好| sku是什么| 梦见换房子是什么预兆| 吃稀饭配什么菜好吃| 为什么来月经会头疼| 蔡明是什么民族| 梦见烧火是什么意思| ihc是什么意思| 好滴是什么意思| 双鱼座女和什么星座最配| 孕妇吃什么牌子奶粉| 什么夕阳| 室内传导阻滞什么意思| 薏米有什么功效| 狮子是什么生肖| 早泄是什么| 壮丁是什么意思| h1v是什么意思| 喝酒胃出血吃什么药| 海鲜不能和什么一起吃| 木瓜什么时候成熟| 什么深似海| 为什么会有肥胖纹| 肚脐眼周围痛挂什么科| 锋芒毕露是什么意思| 促排是什么意思| 什么姓氏排第一| 驾驶证和行驶证有什么区别| 间接胆红素高是什么意思| 尿道感染是什么原因引起的| 怀女孩有什么征兆| 科目三为什么这么难| b超fl是什么意思| 热感冒吃什么药| 过意不去是什么意思| 浮生如梦是什么意思| 无创是什么| 女生胸部长什么样| 前列腺炎吃什么药最好| 属鸡的是什么命| c肽高说明什么| 禅悟是什么意思| 白发多吃什么可以改善| 清真什么意思| 蓝颜知己是什么关系| 额窦炎吃什么药| 糜烂性胃炎有什么症状| 牙龈老是出血是什么原因引起的| 上吐下泻吃什么好| 抑郁气滞是什么症状| 尿痛吃什么药效果最好| 百度Jump to content

文化部关于印发《网络表演经营活动管理办法》的通知

From mediawiki.org
百度 新时期以来,是朝着工作范围更宽和工作对象更多的方向发展的。

Base revision: r105164

ArticleFeedbackv5.php

[edit]
  • Line 82, 103: please be aware that tracking bucketing generates a lot of noise in the tracking data, to the point where it brought the site down once. This can only be enabled on the cluster if we use UDP logging (which we want to do anyway, I just need to get around to enabling it), and I will probably want to have it turned off initially when deploying. Fixed in r105309
    • I couldn't tell from the wording whether this meant the tracking was dangerous (which seemed more likely), or the bucketing was dangerous, so I averted both. The bucket config is now set to ignore = 100 by default, and ext.articleFeedbackv5.js skips bucketing if either track or ignore is set to 100. -- rsterbin
      • I meant the tracking, i.e. generating an event for 'I just put user X in bucket Y' and logging all of those events. I'm sorry for not being clearer; all I asked for was to remove 'tracked' => true, throughout (which has not happened, so my concerns are not addressed with r105309)
  • Yes Done Line 119-129: the keys in the bucket configuration (-, A, B, C) don't match the keys in the documentation comment (0, 1, 2, 3) Fixed in r105262 (rsterbin)
  • Line 161: are you guys even using the survey stuff anymore? If not, it should be stripped out of v5

ArticleFeedbackv5.hooks.php

[edit]
  • Yes Done Line 293-297: debugging code, please comment out or remove. This seems to be unfinished edit tagging functionality? Fixed in r105262 (rsterbin)

ArticleFeedbackv5.i18n.php

[edit]
  • Yes Done Line 35, 50: inconsistency between $1 / 5 (with spaces) and $1/5 (without spaces) Fixed in r105260 (rsterbin)
  • Yes Done Line 39: message key is misspelled (invalud). The correct spelling is used in api/ApiViewFeedbackArticleFeedbackv5.php , which means that code will hit a missing message Fixed in r105260 (rsterbin)
  • Yes Done Line 42: don't capitalize 'Feedback'. Our i18n people don't like Title Case, and 'feedback' isn't capitalized in any of the other messages Fixed in r105260 (rsterbin)
  • Yes Done Our i18n people also prefer 'page' over 'article' but I think Fabrice raised a similar point already Fixed in r105260 (rsterbin) -- Special page only; form fixes will go in as approved
  • Yes Done Line 85: Don't Use Title Case In 'Very Good' Fixed in r105260 (rsterbin)

SpecialArticleFeedback5.php

[edit]

Overall it looks like this special page is very much unfinished, and it is undeployable in its current state. This either needs serious work before deployment, or needs to be disabled by commenting it out from $wgSpecialPages.

  • Yes Done Line 17, 48-50, 53, 55, 56, 61: hardcoded English textFixed in r105627 (gregchiasson)
  • Yes Done Line 22: The Wikipedia:$title thing will not work on Wikipedias, because on those wikis "Wikipedia:" is a namespace prefix rather than an interwiki prefix. There are also general issues with building wikitext this way. You should build links the proper way:
    $linkHTML = Linker::link( $titleObj, wfMessage( 'articlefeedbackv5-foobar' )->escaped() )
    Here $titleObj is a Title object (see also my Title::newFromText() example below) and the second parameter is HTML (which is why you have to escape the i18n message) Fixed in r105617 (gregchiasson)
  • Line 43-44: " This is a terrible, terrible hack. I'm taking it out as soon as I stop being an idiot and sort this ResourceLoader thing out". Would this week be a good time to stop being an idiot? ;) If you have questions regarding ResourceLoader, I can answer them, I wrote half of it. I'll be on vacation Tue-Fri but should be reasonably responsive to e-mail.
  • Yes Done Line 75: MediaWiki has built-in functionality for obtaining a page ID from a title, and unlike your pageIdFromTitle() function it also works for namespaced titles like this page :)
    $title = Title::newFromText( 'Foobar' );
    if ( !$title ) { /* newFromText() returns null for invalid input. Handle error here */ }
    $id = $title->getArticleID(); Fixed in r105617 (gregchiasson)

sql/ArticleFeedbackv5.sql

[edit]

It saddens me to see that my feedback on the schema was largely ignored.

  • Yes Done Line 22: I've told you before that you should really have a user_ip field (IP address or null) field here rather than a user_text field (IP address or user name). The latter is the old style used in most of MW core, the former is the new style used in newer extensions. If you insist on having a user_text field, at least make sure the data type is exactly the same as that of user.user_name (varchar(255) binary)
  • Yes Done Line 34, 35: I've told you before that you should not use MySQL's TIMESTAMP type. You also acknowledged that the modified field wasn't needed because the rows in this table aren't changed, but it's still there
  • Yes Done With the exception of the first table, comments are few and far between. Please add a comment above every table to explain what it contains (this is missing even for the first table -- from the field names I can deduce that it contains individual ratings) and above every field name where the contents of the field aren't immediately obvious from their name (things like auto increment IDs don't need comments, but things like foreign keys, enums and most text fields do) Fixed in r105448 (gregchiasson)

api/ApiArticleFeedbackv5Utils.php

[edit]
  • Yes Done Line 34, 36, 38: please resolve this TODO Fixed in r105449 (gregchiasson)
  • Yes Done Line 54: $wgArticleFeedbackNamespaces is global'ed but $wgArticleFeedbackv5Namespaces is used in the code (and defined in the setup file). You should use error_level(E_ALL) when debugging, that should have caused an E_NOTICE about an undefined variable to appear Fixed in r105252 (rsterbin)
  • Line 98-111: you don't need to write your own getRevisionId() function, there is a built-in function for obtaining the latest revision ID of a page: obtain a Title object and call $title->getLatestRevID() Fixed in r105252 (rsterbin)
    • Still flawed, see CR comment on r105252. Code as written will cause a null pointer dereference when a nonexistent page ID is passed in
  • Yes Done Line 116, 138: per the TODO comments, use memcached here Fixed in r105726 (gregchiasson)
  • Yes Done Line 122-125, 144-147: always pass the __METHOD__ parameter to select() Fixed in r105449 (gregchiasson)
  • Yes Done Line 118: this function passes the return value of select() through unmodified, which means it does not return an array, but a ResultWrapper. These objects are iterable, so in practice you don't notice the difference (you can use foreach on them and such) until you try passing them into array_*() functions and everything explodes. If you document your return values correctly, this is less likely to happen Fixed in r105252 (rsterbin)
  • Yes Done Line 150-152: creating an array before you append to it is something that you need to do in JavaScript (which is annoying as hell), but it's not needed in PHP. In fact, you can even do stuff like $variableThatDidntExistBefore['foo']['bar'][2]['baz'] = 'quux'; and that'll just work. Fixed in r105252 (rsterbin)

api/ApiArticleFeedbackv5.php

[edit]
  • Yes Done Line 38-40: why is this check commented out? Fixed in r105449 (gregchiasson)
  • Yes Done Line 76: TODO ERROR Fixed in r105449 (gregchiasson) -- Not fixed in r105449, but must have been fixed in some later rev cause it's fixed in trunk
  • Yes Done Line 90-104: I'm impressed that you guys put in the Squid purge thing. This is probably the only extension that does this, and it's not something I thought would have been easy to figure out on your own. However, you need to get these things exactly right, if there's the slightest discrepancy it won't work at all:
    • Line 94: this should be list=articlefeedbackv5-view-ratings to match the JS file
    • Line 96: the empty string here betrays that the anontoken parameter is unused. It should be removed here, in the JS file, and in the API module
    • Line 97: afuserrating is even more unused (not defined in the API module, not passed by JS) and should also be removedFixed in r105460 (gregchiasson)
  • Yes Done Line 142: you should never do escaping in an input validation function. Escaping should happen as close to the output as possible. I know this isn't done right now but I recommend removing the comment suggesting this lest anyone read it and implement it Removed in r105246 (rsterbin)
  • Yes Done Line 201: the containing function is called three times, so getRevisionLimit() is also called three times. You should cache its return value somewhere, either in getRevisionLimit() itself or somewhere in this class Fixed in r105460 (gregchiasson)
  • Yes Done Line 211-240: these two queries are poorly indexed. You will need the following:
    • an index on (af_page_id, af_revision_id). There is currently an index on af_revision_id alone, but that is insufficient for this query
    • an index on (afi_data_type)
    • an index on (aa_feedback_id, aa_field_id, aa_response_option_id) Fixed in r105460 (gregchiasson)
    • with all those, the query should be fairly reasonable (although I'll believe that when I EXPLAIN it), but I'd really prefer updating the rollup tables with increments/decrements (UPDATE foo SET bar=bar+1 WHERE baz) over recomputing the values every time. The GROUP BY query is a bit scary, and will probably be slow for heavily rated pages In r105601 (gregchiasson) I changed up the logic to avoid expensive GROUP BY type queries where possible, doing a larger number of much simpler queries instead, and gone back to the old system of incrementing counts, along with adding a number of comments about why I think this makes sense. Page rollups still us the group by, but they only pull from the revision rollups, which might be good enough, I'm not sure. Feel free to re-test, I'm open to suggestion if you think this won't work (I can just insert a billion random rows into our dev DB, and test against that, if I get time).
      • That's much better, thanks. I've left some comments on the revision in code review.
  • Yes Done Line 242: I have no idea what that comment is supposed to tell me Fixed in r105460 (gregchiasson)
  • Yes Done Line 275: am I misinterpreting the meaning of the per-revision rollup tables here? It seems these tables track the numbers for that revision and the 29 revs before it combined, rather than just tracking the numbers for that revision. I can't tell which interpretation is correct because there is no documentation in the code and no documentation in the SQL file either Fixed in r105460 (gregchiasson)
  • Yes Done Line 290-300: instead of that DELETE-INSERT-DELETE-INSERT sequence, you may want to use two REPLACE queries. See DatabaseBase::replace() in includes/db/Database.php As of r105601, there's only one delete/insert block. The replace function looks like it might be worth examing, still. (gregchiasson)
    • That looks better, thanks. I'll mark this as done; using REPLACE is a nice-to-have here and I'm not even sure it'll be much faster
  • Yes Done Line 310: this function is named and documented as a getter, but in reality it inserts a row. Please name and document the function accordingly Fixed in r105246 (rsterbin)
  • Yes Done Line 389, 394, 400, 406, 411, 412, 420, 421: you don't need to specify ISMULTI => false or REQUIRED => false, these are false by default Fixed in r105246 (rsterbin)

api/ApiFlagFeedbackArticleFeedbackv5.php

[edit]
  • Yes Done Line 18: the 'af' prefix conflicts with the v4 modules and with the other two modules. Every query module should have a unique parameter prefix. Also, action= modules conventionally do not have a parameter prefix Removed the prefix in r105487 (gregchiasson)
  • Yes Done Line 31, 43, 49: ideally you would return an error code or message key from the API and have the JS client do the i18n work. This prevents annoying bugs when ?uselang= is used Fixed in r105487 (gregchiasson)

api/ApiViewFeedbackArticleFeedbackv5.php

[edit]
  • A submodule of action=query has to be able to coexist peacefully with its fellow submodules, because any number of submodules can be invoked in the same request. This means you have to
    • choose a unique parameter prefix (line 22, see also comment on ApiFlagFeedback)
    • Yes Done namespace your ApiResult additions by using $this->getModuleName() as the key rather than 'data' (line 49-51). This is done correctly in the ViewRatings module, on line 36 fixed in r105632 (gregchiasson)
  • Line 89: a COUNT(*) query on an unbounded number of rows is unacceptable in production. Doesn't the rollup table have this information? Sort of, but that would break the counts when a filter is active - hidden, visible, etc.
  • Yes Done Line 103-110: we have a choice between DESC sorting and DESC sorting? That looks broken Fixed in r105243 (rsterbin) -- not broken, just repetitive
  • Yes Done Line 119-126: this query has WHERE af_page_id=N ORDER BY af_id, so there should be an index of (af_page_id, af_id) Fixed in r105632 (gregchiasson)
  • Line 123: don't use OFFSET-based paging. Instead, page with WHERE af_page_id >= $params['continue'] and set a query-continue for the next page ID. Grep the core code for query-continue for examples, or ask me
  • Line 188, 200, 203, 206 : as it is, these messages are being treated as raw HTML. This is occasionally OK, but please avoid it wherever possible. The output of these wfMsg() calls should be escaped Fixed in r105717 (gregchiasson)
  • Line 201, 204: use the 'pipe-separator' What does this mean? (gregchiasson)
  • Line 225: $found is the result of a wfMsg() call, should also be escaped Fixed in r105717 (gregchiasson)
  • Line 226: THIS IS A GLARINGLY OBVIOUS STORED XSS VULNERABILITY. You have to escape aa_response_text before putting it in your HTML output Fixed in r105717 (gregchiasson)
  • Line 234, 242, 256: More instances of unescaped database values in the HTML output Fixed in r105717 (gregchiasson)
  • Line 233, 241, 247, 252, 270, 274: More instances of unescaped messages Fixed in r105717 (gregchiasson)

api/ApiViewRatingsArticleFeedbackv5.php

[edit]
  • Yes Done Line 55: you don't need the setIndexedTagname_internal() call here because there are no numerically indexed arrays around Fixed in r105242 (rsterbin)
  • Yes Done Line 75-77: the fetchRevisionRollup() function is unused Fixed in r105242 (rsterbin)
  • Yes Done Line 113: why are you grouping by afi_name? It's unnecessary because you're already grouping by rating_id (and afi_name is derived from that). Also, are afi_id and aa_rating_id joinable against each other? If so, shouldn't the latter be called aa_field_id? I wouldn't have to ask if there were any documentation whatsoever in the SQL file Force of habit from postgres, I guess, where you have to group by every column you're selecting, and I need both ID and name. At any rate, obviated by the below.
    • Yes Done Also, because the revisions branch is dead/unreachable, you can remove the SUM() and GROUP BY parts, right? Correct, and fixed in r105464 (gregchiasson). I'm not entirely sure what I was getting at there, but that query was definitely more complicated than it had to be.
  • Yes Done Line 127, 130: the userrating and subaction parameters are undocumented and unused Fixed in r105242 (rsterbin)
  • Yes Done Line 128, 135-139: the anontoken and revid parameters are unused Fixed in r105242 (rsterbin)

modules/ext.articleFeedbackv5/ext.articleFeedbackv5.startup.js

[edit]
  • Line 23: this is checking the v4 preference name (articlefeedback-disable), should check the v5 preference name (articlefeedbackv5-disable) instead The spec says that v5 should respect users' disable setting for v4 -- rsterbin
  • Yes Done Line 30-32: why does the bucketing happen here rather than in ext.articleFeedbackv5.js ? There's another bucket() call there, so removing the bucket() call here wouldn't break anything, it would just change when the bucketing occurs (and it would bucket way way fewer people in the beginning, that's important) Fixed in r105307 (rsterbin)

modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js

[edit]
  • Yes Done Line 13-14: you can use mw.util.wikiScript( 'api' ) to get the URL for api.php Fixed in r105433 (yonishostak)
  • Yes Done Line 54: "TODO user ID?" yeah strangely the user ID isn't available in JS. But you shouldn't need to pass it to the API module anyway Fixed in r105433 (yonishostak)
  • Yes Done Line 95-97: can't you use $foo.append( bar ) rather than $foo.html( $foo.html() + bar ) ? Fixed in r105433 (yonishostak)
  • Yes Done Line 100, 101: please use .text() rather than .html() for text, it escapes HTML. Using HTML functions for things that aren't really HTML scares me Fixed in r105433 (yonishostak) and r105463 (gregchiasson)

modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js

[edit]
  • Yes Done Line 78: you can't use a self-closing span tag here. IE will choke if you use self-closing span tags in a jQuery constructor Fixed in r105194 (rsterbin)
  • Yes Done Line 93: ditto, closing a tag Fixed in r105194 (rsterbin)

modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js

[edit]
  • Yes Done Line 112: you can use mw.util.wikiScript( 'api' ) to get the URL for api.php Fixed in r105193 (rsterbin)
  • Yes Done Line 243: all your HTML classes and IDs are nicely namespaced, but find-feedback isn't Fixed in r105193 (rsterbin)
  • Yes Done Line 297: this URL is passed in in wgArticleFeedbackv5TermsPage. Bucket 2 does grab this variable Fixed in r105193 (rsterbin)
  • Yes Done Line 363-364, 621-623, 656, 941, 942: why is this commented out? Fixed in r105193 (rsterbin) -- half-implemented idea of disabling the form when the comment was empty; removed for now
  • Yes Done Line 577, 847, 1312: this grabs the proper variable for the terms page URL, but feeding it through wikiGetLink() is wrong, because it's already an absolute URL, not a page name Fixed in r105193 (rsterbin)
  • Yes Done Line 682, 712: t leaks to the global scope Fixed in r105193 (rsterbin)
  • Yes Done Line 776: why is there hardcoded English here? ("Remove this rating") Fixed in r105193 (rsterbin) -- no idea, but it's definitely not needed and gone now
  • Yes Done Line 828: so what is this for? Fixed in r105193 (rsterbin) -- ditto'
  • Yes Done Line 1055: you cannot have an unclosed html:msg tag here (self-closing is OK, that's what's used elsewhere) because it's invalid HTML and IE will barf Fixed in r105193 (rsterbin)
  • Yes Done Line 1156: as written this will bucket all users in a with-expertise and a without-expertise group, even if they're never shown form number 5. It's probably better to move this in a bit deeper so the expertise vs. no expertise bucketing only happens if needed, and we end up bucketing fewer people (=fewer cookies sent around, fewer bucketing events if bucket tracking is enabled) Fixed in r105307 (rsterbin)
  • Yes Done Line 1276-1277: is something missing here? Fixed in r105193 (rsterbin) -- stray outline of old template definition; removed
  • Yes Done Line 1616: the anontoken parameter is not used by this API module and should be removed Fixed in r105193 (rsterbin)
  • Yes Done Line 1618: mw.config.get( 'wgArticleFeedbackSMaxage' ) is called but the setting is called wgArticleFeedbackv5SMaxage Fixed in r105188 (rsterbin)
  • Yes Done Line 1632, 2309: you cannot call console.log() if you're not sure you're in debug mode, it causes a JS error if there is no active debugger Fixed in r105193 (rsterbin) -- I just used a defined check on console; if there's something built in I should be using instead, let me know.
  • Yes Done Line 1782-1796: why is <html:msg> not used here? Fixed in r105193 (rsterbin)
  • Yes Done Line 2028, 2029, 2314: use .text() for message contents, not .html() Fixed in r105193 (rsterbin)
参片泡水喝有什么功效 男人爱出汗是什么原因 扦脚是什么意思 结肠炎吃什么药治疗效果好 什么家常菜好吃
长期喝茶有什么危害 牛跟什么生肖相冲 11月2号是什么星座 牙虫长什么样子 暗的反义词是什么
己是什么意思 打狂犬疫苗挂什么科 乳腺纤维瘤有什么症状表现 肠镜检查挂什么科室 肝炎五项检查是什么
孕妇什么情况下打肝素 大姨妈不来是什么原因造成的 胃痛看什么科 血压偏低是什么原因造成的 骶管囊肿是什么意思
看走眼是什么意思dayuxmw.com 金属过敏用什么药膏hcv7jop5ns5r.cn 新生儿拉肚子是什么原因引起的hcv8jop7ns8r.cn 不加大念什么hcv8jop1ns0r.cn 指甲软是什么原因hcv9jop0ns7r.cn
吃什么对肝脏有好处能养肝hcv9jop4ns9r.cn 为什么海藻敷完那么白hcv8jop6ns6r.cn 荨麻疹吃什么药最管用hcv8jop2ns4r.cn 手麻脚麻是什么原因引起的hcv8jop4ns8r.cn 西兰花和什么菜搭配huizhijixie.com
流产用什么药最快hcv8jop0ns8r.cn 痔疮什么症状hcv8jop3ns3r.cn 疑难杂症是什么意思hcv9jop5ns8r.cn 黄体期什么意思gysmod.com 排卵期后面是什么期hcv9jop8ns2r.cn
吃什么预防脑梗hcv8jop2ns0r.cn 津字五行属什么cl108k.com 无花果吃了有什么好处hcv9jop8ns3r.cn 糖丸是什么疫苗hcv9jop1ns5r.cn 鹅口疮是什么hcv9jop2ns8r.cn
百度